improvement(client-runtime): type createBlobPayloadPending as true | undefined #24466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undefined matching IDocumentSchemaCurrent.runtime and eliminating telemetry noise
github-actions
bot
added
area: runtime
ChumpChief
approved these changes
Apr 25, 2025
| @@ -12,7 +12,7 @@ import { | |||
| type IDocumentSchemaFeatures, | |||
| } from "../summary/index.js"; | |||
|
|
|||
| function boolToProp(b: boolean) { | |||
| function boolToProp(b: boolean | undefined) { | |||
There was a problem hiding this comment.
I see you removed the use of boolToProp below but also modified its params here - are both intended or should it just be one or the other?
There was a problem hiding this comment.
No call is the most correct, but it doesn't matter for test code. I changed this because it can handle undefined and if used when not needed -- okay.
I did not change the production version of boolToProp as in production the call would be a waste.
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matching IDocumentSchemaCurrent.runtime
and eliminating telemetry noise
Follow-up for #24320 before released for use. Document schema is unchanged; only change is runtime option requirements.